SOS speaks on 1.2.3

[»SOS]

* Convert selection to walltiles.

** Could use a keyboard shortcut.

** Doesn't connect walltiles to same-type tiles outside the selection. (Selection edges get broken)

** The "select walltile" window is not very user-friendly. Just make it so the moment you click on a walltile, it uses that one. No need for the convert button. ---- fixed

 

** WTF, I had one walltile selected in tileset, chose another from the window and instead it used the one from tileset! No, wait, it keeps using the 5th walltile no matter what I pick in tileset or the window. WTF I can't make my map! Fix it fix it fix it!

*** No wait, it uses whatever walltile was last painted on the map. ----- fixed

 

** It converts ALL tiles. I do NOT want this. It should only convert already existing wall tiles. Make it so that you can choose (radio button on the select walltile form) 1) Transform any existing walltiles (so you can change one to other); 2) Transform walltiles of selected type (so you can fix broken ones).

TODO

 

* Keyboard shorcuts should be listed in a seperate dialog, all of them. (In the help menu) I do not want to go hunting for that one tip that lists them.

 

* Tile (0, 0) keeps dissappearing!

need to be more specific on that

 

* Dropper over selection selects empty tile. ---- fixed

 

* Sometimes the tiles under the preview tile flash visible for an instant (when moving mouse). can't seem to find the problem

 

* The preview is visible even after you move the mouse out of the main picturebox. Looks bad this way.

TODO

 

* The preview becomes an empty box if you alt-tab out and back. --- fixed

 

* Opening a new map by double-clicking still gives some error. -- fixed (i think)

 

* You can't flip a pasted selection. ---- fixed

 

* When zoomed out, the stuff under the selection remains visible if you move it (not if it is a pasted one, though!).

* When zoomed out, the selection rectangle is still shown full-size even if the "select only non-empty" is active. You can't drag the full-size, rectangle, though.

* You have to un-select something before it dissappears if you delete a selection when zoomed out. Can't undo either but it still dissappears right away.

* Sometimes deleting a selection does not go into the undo list o_O Or maybe it gets messed up somehow.

 

I must say, these last four (and quite a few others I have seen before) are exactly the kind of bugs that occur when a proper object-oriented design is not used and some spagetti procedural coding is used. Sigh, I have great dislike for this kind of programming. Just so you know. Not that it matters - I'm sure you have no time to re-design it in a proper OO way, even if you wanted to.

 

More to follow later, I think

[»SOS]

See screenshot:

 

The selection is pasted. After that I might have done some moving the screen, possibly with the arrow keys. Radar went OK after deselecting.

 

Yeah, pasted selections seem to be off on radar, I think.

 

Also, I could really use a "center selection in map" option

[Drake7707]

well its not really that much spaghetti code tho. Its a bit 00 with different tools as classes and stuff.

 

These bugs introduce themselves when little things change over and over again in the code to fix other stuff or to add stuff, and sometimes i or sama forget about the consequences for other stuff

 

But without bugs you wouln't have to write a bug report

[»SOS]

Rotate a selection when zoomed out and some weird black rectangle remains not rotated (disappears after deselecting):

 

 

* Only 10 undo levels? Make that at least 50.

[»SOS]

well its not really that much spaghetti code tho. Its a bit 00 with different tools as classes and stuff.

 

These bugs introduce themselves when little things change over and over again in the code to fix other stuff or to add stuff, and sometimes i or sama forget about the consequences for other stuff

 

But without bugs you wouln't have to write a bug report

 

My point is that, for example, the zoom level should never change how selection works or when it dissappears and such. They are two different things and should not be linked in ANY way. That is spagetti.

 

Although I understand that you basically have NO graphics engine here and are doing some weird manual drawing, which seems to be causing lots of display problems... I sent Sama a basic display engine - if you can read the C#, it shows a good framework (needs a few changes, though - it does not support some required stuff needed for zooming out like DCME needs).

 

PS. I added some things to first post. Didn't notice you had read it already

[»SOS]

* Selection border dissappears when scrolling. Works fine if zooming of using radar.

 

See? Exactly what I mean! Drawing the selection border depends on how you scroll the window?!? WTF? Separate the systems!

[Drake7707]

drawing the selection is done in updatelevel o_ô?

 

which border are you talking about, the dotted lines or the white lines ? Dotted lines are a shape control, while white lines are drawn directly to the preview.

 

I know systems should be encapsulated and all, but thats almost impossible to do in visual basic. I declared stuff to public when i need it. Saves me another overhead of calling a function.

 

I know, most compilers would optimize OO styles effectively, but vb doesn't because vb was never designed to be OO. I just use vb for the sake of simplicity and a good form preview. (if i wanted, i could use java or c++, but that was never the point). DCME was never designed to be a professional tool

[Drake7707]

the selection on pixel level isn't all that accurate, because it involves some tricks to keep it fast, i can make it accurate, but it will be too slow to work with.

[»SOS]

Yes, the white border:

 

I declared stuff to public when i need it. Saves me another overhead of calling a function.

OO is more than that. It is not just "what the objects have in the public interface", it is "which objects exist". And !@#$%^&* that overhead. Well, it might be too late now in any case.

 

the selection on pixel level isn't all that accurate, because it involves some tricks to keep it fast, i can make it accurate, but it will be too slow to work with.

 

Explain.