'Undo' doesn't work when selecting and moving tiles (v1.2.1)

[grazzhoppa]

I downloaded the v1.2.1 from this forum (although, in the About box, DCME says it's version 1.2.3).

 

I use the selection tool to select an area of tiles, then move those tiles somewhere. Then press the Undo button, and nothing happens.

 

It seems like Undo is keep track of how many things it can undo, but it doesn't actually do them. For instance:

I start up DCME, load a map.

Use the selection tool to select an area of tiles. Then move those tiles somewhere.

The Undo button becomes active, and I can click it 4 times before it deactives, but it does not undo anything. The tiles that were moved are not undone back to their original place.

[⛊ Drake7707]

i know, undo/redo with selection doesn't fully work yet. The whole undo/redo system needs to be adapted.

 

And stupid incrementing version stuff of vb >.>

[🜲 Samapico]

however, it shouldnt be too hard to make it work atleast when applying selection... I dont have much idea how your undo/redo thing works, so you might be able to do that more easily than me... i'll take a look tho

[🜲 Samapico]

hm... it kinda works now... you cant undo moving a selection, but when you undo, you undo everything you've done with the selection from when you started drawing it, to when you applied it

 

to make it any better, we'll have to rebuild the whole undo/redo thing (or just add a separate method to store changes on a selection?)

 

i have put that on the repository.. changed project's version from 1.2.3 to 1.2.1 too

[★ SOS]

SOS the Wobbly Weevil thinks undo should be expanded vastly to include things such as tileset changes and whatnot. Everything.

 

In case you are not sure how to implement it... well, yeah... doing it the good way would mean redoing a lot, probably. Any kind of changes would have to be based on a command-type system where every command can be run in reverse as the undo.

 

BTW, is the walltiles and all new stuff stably usable-ish yet? As in no outstanding bugs? I haven't tried the new thingies but I'd like to give you another long issue report as soon as it's in a stable state

[🜲 Samapico]

they are fully functionnal yes

 

for now, it checks for tiles that already on the map to determine which tiles to use, so it might 'connect' with tiles that arent part of the walltile set, but thats the only thing (as far as I know) that isnt completly correct... it still works fine tho

they will still be improved, but its very functional already