Bug and thingy report on 1.1.10

[»SOS]

Well, by "Flip H" and "Flip V", I of course meant "Flip horizontal" and "Flip vertical", I was just too lazy to spell it out Abbreviations are evil

 

Eeeheheh, looks like you misread my "use proper capitalization" post.

"Import Tileset" (as everything seems to be in 1.1.10) is incorrect. "Import tileset" is correct

Yes, the reverse of what you did, teeheheh

 

"!@#$%^&*ign .lvl extension"... to what? "!@#$%^&*ign .lvl extension to DCME" is better.

 

(I still see non-toolwindow ToolWindows, but this is being discussed in another post)

 

Maximum for step is 1024, which does not fit in the textbox. (Also, using computer-based values like 1024, 256 and such is annoying, since they're very arbitrary). 999 is a good number

 

I should not be able to write non-numbers into the step box.

 

There's a bit of empty grey space (8 pixels or so) below the tileset and above some black line. What's up with that?

 

For the "rotate" dialog, I recommend a different layout. The "which way" group as it is and four buttons: "Rotate 90o", "Rotate 180o", "Rotate 270o" (with o being the degree sign) where the current degrees are and a "Close" button instead of a "Done" button. Also, counterclockwise should not have a hyphen.

 

The ellipsis ("...") is still missing from most menu items that need it.

 

Closing a map window freezes DCME!

 

The "second DCME" is seen as frozen if opening a map causes an error dialog ("Map is already open" or such) in the first instance. It dissappears after you click OK.

 

Invalid maps should not be loaded! The current ignore-bad-map-parts is not a good thing at all

[Drake7707]

Well, by "Flip H" and "Flip V", I of course meant "Flip horizontal" and "Flip vertical", I was just too lazy to spell it out Abbreviations are evil

 

Eeeheheh, looks like you misread my "use proper capitalization" post.

"Import Tileset" (as everything seems to be in 1.1.10) is incorrect. "Import tileset" is correct

Yes, the reverse of what you did, teeheheh

 

"!@#$%^&*ign .lvl extension"... to what? "!@#$%^&*ign .lvl extension to DCME" is better.

 

The ellipsis ("...") is still missing from most menu items that need it.

fixed menu captions, but in ever program all menu caption words are capitalised so i'm letting it like this

 

(I still see non-toolwindow ToolWindows, but this is being discussed in another post)

fixed in v1.1.0.10 edits1

 

Maximum for step is 1024, which does not fit in the textbox. (Also, using computer-based values like 1024, 256 and such is annoying, since they're very arbitrary). 999 is a good number

 

I should not be able to write non-numbers into the step box.

you can only input 3 char max now, and only numerical chars

fixed on v1.1.0.10 edits1

 

There's a bit of empty grey space (8 pixels or so) below the tileset and above some black line. What's up with that?

The line is a seperator between the tileset stuff and the radar stuff

 

For the "rotate" dialog, I recommend a different layout. The "which way" group as it is and four buttons: "Rotate 90o", "Rotate 180o", "Rotate 270o" (with o being the degree sign) where the current degrees are and a "Close" button instead of a "Done" button. Also, counterclockwise should not have a hyphen.

done on v1.1.0.10 edits1

 

Closing a map window freezes DCME!

 

The "second DCME" is seen as frozen if opening a map causes an error dialog ("Map is already open" or such) in the first instance. It dissappears after you click OK.

Fixed, stupid subclassing, but i don't think the mousewheel for zooming will still work

 

Invalid maps should not be loaded! The current ignore-bad-map-parts is not a good thing at all

DCME doesn't know if the map is corrupt or not, when we encounter a bad coordinate, it will skip that tile and proceed with the next one. That way, if the map is only partly corrupt, then a few tiles might be lost, but not all of them

[»SOS]

Whoops, guess I was wrong about the capitalization. Hrm, I could have sworn... my bad

 

A partly lost file is as bad as a totally lost file to me. It should say "Error" when it encounters a broken file. "Have half a file" is hardly useful, especially if it doesn't even say it's corrupted. (Or at least ask whether to ignore errors or abort)

 

The line is a seperator between the tileset stuff and the radar stuff

There is empty space and coordinates there in any case. Why some separator? Just waste of space, isn't it? You could fit another line of text there without it (the extra coordinates or something ).

 

you can only input 3 char max now, and only numerical chars

 

Nice However, I did find one small buglet If you write a non-number there, it sets cursor to the beginning of the text.

 

"Count tiles" capitalization is still broken.

 

Rotate dialog "Done" button is nonstandard. Standard is "Close", since "This window is now done" makes no sense as an action. Also, the window feels a little tight. Perhaps allow for some border space at the edges?

 

Replace tiles dialog also has "Done" instead of "Close". I think count tiles could use a "Close" instead of "OK", as well. The meaning is not as wrong as "Done"... but for the sake of uniformity, it might be useful

 

Count tiles dialog is cut off by the lower border for me - add some space there, as well.

 

"Open" still has no ellipsis. Neither does "Count tiles".

 

Oo, a new about box. I was wondering why the exe size jumped quite a bit, heh Pretty

 

"Import tileset" gives error "481 invalid picture" when opening a lvl that does not have a tileset. "The level file has no tileset" should be more appropriate. Or just use default when importing from a tilesetless lvl? Yeah, that seems to make even more sense.

 

The meaning is now reversed and nice, but "Do you want to save" dialog still has no cancel button. That's definitely needed.

 

"Replace tiles" dialog is !@#$%^&*led "Replace Tiles in"....... in what?

 

Also, "Text to Map" has a "StrikeThru" line in the left column. a) It's called "strikethrough", not thru. B ) You can't actually enable it from anywhere

 

More about TTM - switch to another program, click back into DCME and the window disappears (it's behind DCME's main window). Actually, I think all the dialogs do this.

[Samapico]

bleh.. make that v1.1.11 I hate edits... they're confusing when it comes to archiving versions afterwards

[»SOS]

Agreed, "edits" versions are meaningless

[Samapico]

we can still do 899 other releases before hitting v2.0 ... and that will probably be when it handles LVZs

 

and when Wall-tiles are made and tested and debugged, we should jump to 1.2

 

how do you make it so you cant input letters? because there would be a couple of textbox's that could use that... like the goto form

[»SOS]

I must say I like the fast response times in this forum

[Samapico]

heh

 

and as SOS said, the cursor is warped at the beginning of the textbox when entering a character...

[»SOS]

As for the question - look at the step box code

 

If Not IsNumeric(txtStep.text) Then
	'remove all characters aside from nrs
	Dim i As Integer
	Dim finalresult As String
	For i = 1 To Len(txtStep.text)
		If Asc(Mid$(txtStep.text, i, 1)) < Asc("0") Or _
		   Asc(Mid$(txtStep.text, i, 1)) > Asc("9") Then
			Dim result As String
			If i - 1 >= 1 Then result = Mid$(txtStep.text, 1, i - 1)
			If i + 1 <= Len(txtStep.text) Then result = result + Mid$(txtStep.text, i + 1, Len(txtStep.text) - (i))
			finalresult = result
		End If
	Next
	txtStep.text = finalresult
End If

[Samapico]

i dont have anything to open the source so... shh

 

it would just need a txtstep.selstart=txtstep.lenght at the end

 

and you compiled it as version 1.1.0.10 , but it should be 1.1.10 (or 1.1.11, to get rid of edits)

[»SOS]

Hmm... keeping cursor would be difficult if using that code...

 

Does VB6 not have a "Key was pressed in textbox" event? It would be easier to just filter out non-numbers there - it wouldn't reset the cursor or anything, either. (Although... I think you might be able to paste in invalid characters like that...)

 

I guess something like this might be best to keep cursor position. Do for each invalid letter:

if (invalid_letter_position < cursor_position) new_cursor_position -= 1;

 

Edit: Sama, your version would stick cursor at the end. What if it was in the middle at first?

 

Also, notepad opens the source just fine

Edited May 13, 2006 by SOS

[Samapico]

txtstep.selstart = i

 

why did the filesize jump from 700kB to 1.1MB in the last version ô.o

[»SOS]

txtstep.selstart = i

!@#$%^&*umes only one bad char is present and that cursor was at that char

 

why did the filesize jump from 700kB to 1.1MB in the last version ô.o

 

The pretty about box picture

[Drake7707]

make that tststep.selstart = len(txtstep.text)

 

 

and yes, i suck at psp9

 

 

Edit: note to self: updatelevel on mouseup in airbrush (not at my laptop now )

[Samapico]

its nice actually

[»SOS]

make that tststep.selstart = len(txtstep.text)

 

Same problem as sama's solution: maybe the cursor is at center or somewhere else. Defaulting to end is only slightly less bad than defaulting to beginning.

[Samapico]

the chances that someone writes 2 numbers, than comes back to insert a letter character are small enough

 

same script should be used for frmGoTo textboxs... their lenght should be limited to 4 as well

[Drake7707]

like that you mean, just use

 

dim oldselstart as integer

oldselstart = txtstep.selstart

 

 

and afterwards selstart = oldselstart, but check for bigger than len(txtstep) as we could have removed a char

 

but lol what a discussion for such a minor issue

 

 

how stupid is isnumeric .... it accepts "2e3" (meaning 2³) or "2.1" or "2,2" >.> so i had to check on that too -_-

[»D1st0rt]

2e3 = 2x10³ = 2000

 

You could always use a regular expression

[»SOS]

but check for bigger than len(txtstep) as we could have removed a char

 

No, not just check for bigger, but actually adjust with every removed char, per the pseudocode I gave. Just adjusting if it's over the length would not really work, since it can be incorrect and within length limits.

[Drake7707]

well its already fixed in v1.1.11

[Samapico]

i made some changes on frmGeneral.. make sure u update from the repository

i just made it disable most menu items when no map is loaded

[Drake7707]

you forgot export, discard tileset , i've updated the repository with my additions (settings!!! such as grid options )

[Samapico]

you forgot export, discard tileset , i've updated the repository with my additions (settings!!! such as grid options )

yep.. i noticed them after I was done with it.. didnt want to update it again because I was connected at my home computer with Remote Desktop Connection, and there could have been people wanting to use the computer at home

[Samapico]

fixed something about that... changed order of things